🐛 fire onDidChangePythonProjects event on project change#1642
Closed
Yashraj-Jangra wants to merge 1 commit into
Closed
🐛 fire onDidChangePythonProjects event on project change#1642Yashraj-Jangra wants to merge 1 commit into
Yashraj-Jangra wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Thx for the contribution. Unfortunately this is already solved by #1641 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where the public
onDidChangePythonProjectsAPI event never fired when projects were added or removed at runtime.Cause
The public
onDidChangePythonProjectsemitter was declared inPythonEnvironmentApiImplbut was never actually fired. The API layer also wasn't subscribed to the project manager's internal project change events.Changes
PythonEnvironmentApiImplfor unit testing.projectManager.onDidChangeProjectsin the constructor.addedandremovedprojects) on changes, firing the public event when projects are modified.Verification
src/test/features/pythonApi.unit.test.tsto verify the delta logic.src/test/integration/pythonProjects.integration.test.ts.